linux-kernel - Re: [PATCH] irqchip: armada: avoid unused function warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 18 Jul 2016 19:22:31 +0000
From:	Jason Cooper <jason@...edaemon.net>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Ingo Molnar <mingo@...nel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Marc Zyngier <marc.zyngier@....com>,
	Gregory CLEMENT <gregory.clement@...e-electrons.com>,
	Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>,
	"David S. Miller" <davem@...emloft.net>,
	Richard Cochran <rcochran@...utronix.de>,
	linux-kernel@...r.kernel.org,
	Anna-Maria Gleixner <anna-maria@...utronix.de>
Subject: Re: [PATCH] irqchip: armada: avoid unused function warnings

+ Anna-Maria

Hey Arnd,

On Mon, Jul 18, 2016 at 06:03:21PM +0200, Arnd Bergmann wrote:
> When building with CONFIG_SMP disabled, we get some new harmless warnings:
> 
> drivers/irqchip/irq-armada-370-xp.c:356:12: error: 'mpic_cascaded_starting_cpu' defined but not used [-Werror=unused-function]
>  static int mpic_cascaded_starting_cpu(unsigned int cpu)
>             ^~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/irqchip/irq-armada-370-xp.c:349:12: error: 'armada_xp_mpic_starting_cpu' defined but not used [-Werror=unused-function]
>  static int armada_xp_mpic_starting_cpu(unsigned int cpu)
> 
> This moves the unused functions into the #ifdef, as they previously were.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> Fixes: cb5ff2d245c1 ("irqchip/armada-370-xp: Convert to hotplug state machine")
> ---
>  drivers/irqchip/irq-armada-370-xp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Acked-by: Jason Cooper <jason@...edaemon.net>

Anna-Maria, can you make sure this gets pulled in with the cpuhp
changes?  afaict, cb5ff2d245c1 is only in the tip/WIP.hotplug and
tip/master.

thx,

Jason.