linux-kernel - Re: [PATCH -next] module: use kmemdup rather than duplicating its implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87h9bmof7y.fsf@rustcorp.com.au>
Date:	Tue, 19 Jul 2016 06:07:05 +0930
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	weiyj_lk@....com
Cc:	Wei Yongjun <yongjun_wei@...ndmicro.com.cn>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] module: use kmemdup rather than duplicating its implementation

weiyj_lk@....com writes:
> From: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
>
> Use kmemdup rather than duplicating its implementation.
>
> Generated by: scripts/coccinelle/api/memdup.cocci
>
> Signed-off-by: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>

Hi Wei!

        This code has been removed by other changes in modules-next,
so your very nice cleanup is no longer necessary.

Thanks!
Rusty.

> ---
>  kernel/module.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/kernel/module.c b/kernel/module.c
> index beaebea..04de59f 100644
> --- a/kernel/module.c
> +++ b/kernel/module.c
> @@ -1994,21 +1994,20 @@ static int copy_module_elf(struct module *mod, struct load_info *info)
>  
>  	/* Elf section header table */
>  	size = sizeof(*info->sechdrs) * info->hdr->e_shnum;
> -	mod->klp_info->sechdrs = kmalloc(size, GFP_KERNEL);
> +	mod->klp_info->sechdrs = kmemdup(info->sechdrs, size, GFP_KERNEL);
>  	if (mod->klp_info->sechdrs == NULL) {
>  		ret = -ENOMEM;
>  		goto free_info;
>  	}
> -	memcpy(mod->klp_info->sechdrs, info->sechdrs, size);
>  
>  	/* Elf section name string table */
>  	size = info->sechdrs[info->hdr->e_shstrndx].sh_size;
> -	mod->klp_info->secstrings = kmalloc(size, GFP_KERNEL);
> +	mod->klp_info->secstrings = kmemdup(info->secstrings, size,
> +					    GFP_KERNEL);
>  	if (mod->klp_info->secstrings == NULL) {
>  		ret = -ENOMEM;
>  		goto free_sechdrs;
>  	}
> -	memcpy(mod->klp_info->secstrings, info->secstrings, size);
>  
>  	/* Elf symbol section index */
>  	symndx = info->index.sym;