linux-kernel - Re: [PATCH 2/2] net: ethernet: adi: bfin_mac: use phy_ethtool_{get|set}_link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160717.232251.1118461470001037366.davem@davemloft.net>
Date:	Sun, 17 Jul 2016 23:22:51 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	tremyfr@...il.com
Cc:	andrew@...n.ch, sudipm.mukherjee@...il.com, mugunthanvnm@...com,
	felipe.balbi@...ux.intel.com, treding@...dia.com, fw@...len.de,
	linux@...ck-us.net, adi-buildroot-devel@...ts.sourceforge.net,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] net: ethernet: adi: bfin_mac: use
 phy_ethtool_{get|set}_link_ksettings

From: Philippe Reynes <tremyfr@...il.com>
Date: Sun, 17 Jul 2016 01:10:15 +0200

> There are two generics functions phy_ethtool_{get|set}_link_ksettings,
> so we can use them instead of defining the same code in the driver.
> 
> There was a check on CAP_NET_ADMIN in bfin_mac_ethtool_setsettings,
> but this check is already done in dev_ethtool, so no need to repeat
> it before calling the generic function.
> 
> Signed-off-by: Philippe Reynes <tremyfr@...il.com>

Applied.