linux-kernel - Re: [PATCH v2 2/3] acpi i2c: Initialize info.type from of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160719070705.GN14693@lahna.fi.intel.com>
Date:	Tue, 19 Jul 2016 10:07:05 +0300
From:	Mika Westerberg <mika.westerberg@...ux.intel.com>
To:	"Rafael J. Wysocki" <rafael@...nel.org>
Cc:	Crestez Dan Leonard <leonard.crestez@...el.com>,
	ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
	"Rafael J. Wysocki" <rjw@...ysocki.net>,
	Jarkko Nikula <jarkko.nikula@...el.com>,
	Len Brown <lenb@...nel.org>,
	linux-i2c <linux-i2c@...r.kernel.org>,
	Wolfram Sang <wsa@...-dreams.de>,
	linux-spi <linux-spi@...r.kernel.org>,
	Mark Brown <broonie@...nel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Octavian Purdila <octavian.purdila@...el.com>
Subject: Re: [PATCH v2 2/3] acpi i2c: Initialize info.type from of_compatible

On Wed, Jul 13, 2016 at 02:20:57PM +0200, Rafael J. Wysocki wrote:
> On Wed, Jul 13, 2016 at 1:53 PM, Crestez Dan Leonard
> <leonard.crestez@...el.com> wrote:
> > When using devicetree i2c_board_info.type is set to the compatible
> > string with the vendor prefix removed. For I2C devices described via
> > ACPI the i2c_board_info.type string is set to the ACPI device name. When
> > using ACPI and DT ids this string ends up something like "PRP0001:00".
> >
> > If the of_compatible property is present try to use that instead. This
> > makes it easier to instantiate i2c drivers through ACPI with DT ids.
> >
> > Signed-off-by: Crestez Dan Leonard <leonard.crestez@...el.com>
> 
> Looks good to me, but Mika needs to have a look at it too.

Looks good to me,

Reviewed-by: Mika Westerberg <mika.westerberg@...ux.intel.com>