linux-kernel - Re: [PATCH v15 06/10] arm64: Treat all entry code as non-kprobe-able

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <578D7A14.6070008@linaro.org>
Date:	Mon, 18 Jul 2016 20:53:40 -0400
From:	David Long <dave.long@...aro.org>
To:	Catalin Marinas <catalin.marinas@....com>
Cc:	Huang Shijie <shijie.huang@....com>,
	James Morse <james.morse@....com>,
	Marc Zyngier <marc.zyngier@....com>,
	Pratyush Anand <panand@...hat.com>,
	Sandeepa Prabhu <sandeepa.s.prabhu@...il.com>,
	Will Deacon <will.deacon@....com>,
	William Cohen <wcohen@...hat.com>,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	Steve Capper <steve.capper@...aro.org>,
	Masami Hiramatsu <mhiramat@...nel.org>,
	Li Bin <huawei.libin@...wei.com>,
	Jisheng Zhang <jszhang@...vell.com>,
	Mark Rutland <mark.rutland@....com>,
	Daniel Thompson <daniel.thompson@...aro.org>,
	Vladimir Murzin <Vladimir.Murzin@....com>,
	Petr Mladek <pmladek@...e.com>,
	Ard Biesheuvel <ard.biesheuvel@...aro.org>,
	Jens Wiklander <jens.wiklander@...aro.org>,
	Robin Murphy <robin.murphy@....com>,
	Mark Brown <broonie@...nel.org>,
	Suzuki K Poulose <suzuki.poulose@....com>,
	Dave P Martin <Dave.Martin@....com>,
	Andrey Ryabinin <ryabinin.a.a@...il.com>,
	yalin wang <yalin.wang2010@...il.com>,
	Yang Shi <yang.shi@...aro.org>,
	Zi Shen Lim <zlim.lnx@...il.com>,
	John Blackwood <john.blackwood@...r.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Alex Bennée <alex.bennee@...aro.org>,
	Adam Buchbinder <adam.buchbinder@...il.com>,
	Christoffer Dall <christoffer.dall@...aro.org>
Subject: Re: [PATCH v15 06/10] arm64: Treat all entry code as non-kprobe-able

On 07/15/2016 12:47 PM, Catalin Marinas wrote:
> On Fri, Jul 08, 2016 at 12:35:50PM -0400, David Long wrote:
>> --- a/arch/arm64/kernel/entry.S
>> +++ b/arch/arm64/kernel/entry.S
>> @@ -243,6 +243,7 @@ tsk	.req	x28		// current thread_info
>>    * Exception vectors.
>>    */
>>
>> +	.pushsection ".entry.text", "ax"
>>   	.align	11
>>   ENTRY(vectors)
>>   	ventry	el1_sync_invalid		// Synchronous EL1t
>> @@ -781,3 +782,5 @@ ENTRY(sys_rt_sigreturn_wrapper)
>>   	mov	x0, sp
>>   	b	sys_rt_sigreturn
>>   ENDPROC(sys_rt_sigreturn_wrapper)
>> +
>> +	.popsection
>
> Does the above sigreturn wrapper need to be included in the .entry.text
> section?
>

Apparently not. It wouldn't make sense for that to be in entry.text when 
sys_rt_sigreturn() isn't. I'll put that in the list of changes.

Thanks,
-dl