linux-kernel - Re: [PATCH 3.12 42/88] netfilter: x_tables: do compat validation via translate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160719084004.GB29897@breakpoint.cc>
Date:	Tue, 19 Jul 2016 10:40:04 +0200
From:	Florian Westphal <fw@...len.de>
To:	Michal Kubecek <mkubecek@...e.cz>
Cc:	Jiri Slaby <jslaby@...e.cz>, stable@...r.kernel.org,
	linux-kernel@...r.kernel.org, Florian Westphal <fw@...len.de>,
	Pablo Neira Ayuso <pablo@...filter.org>
Subject: Re: [PATCH 3.12 42/88] netfilter: x_tables: do compat validation via
 translate_table

Michal Kubecek <mkubecek@...e.cz> wrote:
> > -	/* And one copy for every other CPU */
> > -	for_each_possible_cpu(i)
> > -		if (newinfo->entries[i] && newinfo->entries[i] != entry1)
> > -			memcpy(newinfo->entries[i], entry1, newinfo->size);
> 
> These four lines should be preserved, IMHO, as 3.12 doesn't have commit
> 482cfc318559 ("netfilter: xtables: avoid percpu ruleset duplication")
> (introduced in 4.2) which removed the need for per-cpu copies.
> 
> The same applies to the other two instances of translate_compat_table()
> in net/ipv4/netfilter/ip_tables.c and net/ipv6/netfilter/ip6_tables.c
> 
> Florian, do you agree?

Sorry, I have to look at this in more detail.
The patches change the compat translation version into a preprocessing
step rather than a 1:1 replacement of translate_table.

>From first glance the removal is thus ok.
I will review this later today.

Also, please be aware of this bug:
http://patchwork.ozlabs.org/patch/648446/

If possible this patchset should not be pushed to all -stable
kernels yet.