linux-kernel - Re: [PATCH v4 2/2] Bindings documentation for ISSI is31fl319x driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 19 Jul 2016 10:52:56 +0200
From:	Jacek Anaszewski <j.anaszewski@...sung.com>
To:	"H. Nikolaus Schaller" <hns@...delico.com>
Cc:	Rob Herring <robh+dt@...nel.org>, Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Richard Purdie <rpurdie@...ys.net>, drivshin.allworx@...il.com,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-leds@...r.kernel.org, kernel@...a-handheld.com,
	marek@...delico.com, letux-kernel@...nphoenux.org,
	Andrey Utkin <andrey_utkin@...tmail.com>
Subject: Re: [PATCH v4 2/2] Bindings documentation for ISSI is31fl319x driver

Hi Nikolaus,

On 07/19/2016 10:03 AM, H. Nikolaus Schaller wrote:
> Signed-off-by: H. Nikolaus Schaller <hns@...delico.com>
> ---
>   .../devicetree/bindings/leds/is31fl319x.txt        | 56 ++++++++++++++++++++++
>   1 file changed, 56 insertions(+)
>   create mode 100644 Documentation/devicetree/bindings/leds/is31fl319x.txt
>
> diff --git a/Documentation/devicetree/bindings/leds/is31fl319x.txt b/Documentation/devicetree/bindings/leds/is31fl319x.txt
> new file mode 100644
> index 0000000..c42c89c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/leds/is31fl319x.txt
> @@ -0,0 +1,56 @@
> +LEDs connected to is31fl319x LED controller chip
> +
> +Required properties:
> +- compatible : Should be any of
> +	"issi,is31fl3190"
> +	"issi,is31fl3191"
> +	"issi,is31fl3193"
> +	"issi,is31fl3196"
> +	"issi,is31fl3199"
> +	"si-en,sn3199".
> +- #address-cells: Must be 1.
> +- #size-cells: Must be 0.
> +- reg: 0x64, 0x65, 0x66, 0x67.
> +
> +Optional properties:
> +- audio-gain-db : audio gain selection for external analog modulation input.
> +	Valid values: 0 - 21, step by 3 (rounded down)
> +	Default: 0
> +
> +Each led is represented as a sub-node of the issi,is31fl319x device.
> +There can be less leds subnodes than the chip can support but not more.
> +
> +Required led sub-node properties:
> +- reg : number of LED line
> +	Valid values: 1 - number of leds supported by the chip variant.
> +
> +Optional led sub-node properties:
> +- label : see Documentation/devicetree/bindings/leds/common.txt.
> +- linux,default-trigger :
> +	see Documentation/devicetree/bindings/leds/common.txt.
> +- led-max-microamp : (optional)
> +	Valid values: 5000 - 40000, step by 5000 (rounded down)
> +	Default: 20000 (20 mA)
> +	Note: a driver will take the lowest of all led limits since the
> +	chip has a single global setting.

I'd mention here that the lowest value will be chosen due to the
PWM specificity, where lower brightness is achieved by reducing
the frequency of pulses and not the current, which will always
have its peak value equal to led-max-microamp.

> +
> +Examples:
> +
> +fancy_leds: leds@65 {
> +	compatible = "issi,is31fl3196";
> +	#address-cells = <1>;
> +	#size-cells = <0>;
> +	reg = <0x65>;
> +
> +	red_aux: led@1 {
> +		label = "red:aux";
> +		reg = <1>;
> +		led-max-microamp = <10000>;
> +	};
> +
> +	green_power: led@5 {
> +		label = "green:power";
> +		reg = <5>;
> +		linux,default-trigger = "default-on";
> +	};
> +};
>


-- 
Best regards,
Jacek Anaszewski