linux-kernel - Re: [PATCH v1] mm: hugetlb: remove incorrect comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160719091052.GC9490@dhcp22.suse.cz>
Date:	Tue, 19 Jul 2016 11:10:53 +0200
From:	Michal Hocko <mhocko@...nel.org>
To:	Naoya Horiguchi <n-horiguchi@...jp.nec.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Zhan Chen <zhanc1@...rew.cmu.edu>, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org,
	Naoya Horiguchi <nao.horiguchi@...il.com>
Subject: Re: [PATCH v1] mm: hugetlb: remove incorrect comment

On Tue 19-07-16 11:08:18, Naoya Horiguchi wrote:
> dequeue_hwpoisoned_huge_page() can be called without page lock hold,
> so let's remove incorrect comment.

Could you explain why the page lock is not really needed, please? Or
what has changed that it is not needed anymore?

Thanks!

> 
> Reported-by: Zhan Chen <zhanc1@...rew.cmu.edu>
> Signed-off-by: Naoya Horiguchi <n-horiguchi@...jp.nec.com>
> ---
>  mm/hugetlb.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git v4.7-rc7/mm/hugetlb.c v4.7-rc7_patched/mm/hugetlb.c
> index c1f3c0b..26f735c 100644
> --- v4.7-rc7/mm/hugetlb.c
> +++ v4.7-rc7_patched/mm/hugetlb.c
> @@ -4401,7 +4401,6 @@ follow_huge_pud(struct mm_struct *mm, unsigned long address,
>  
>  /*
>   * This function is called from memory failure code.
> - * Assume the caller holds page lock of the head page.
>   */
>  int dequeue_hwpoisoned_huge_page(struct page *hpage)
>  {
> -- 
> 2.7.0
> 
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@...ck.org.  For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@...ck.org"> email@...ck.org </a>

-- 
Michal Hocko
SUSE Labs