linux-kernel - Re: [PATCH 3.12 42/88] netfilter: x_tables: do compat validation via translate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160719094522.GB17120@unicorn.suse.cz>
Date:	Tue, 19 Jul 2016 11:45:22 +0200
From:	Michal Kubecek <mkubecek@...e.cz>
To:	Florian Westphal <fw@...len.de>
Cc:	Jiri Slaby <jslaby@...e.cz>, stable@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Pablo Neira Ayuso <pablo@...filter.org>
Subject: Re: [PATCH 3.12 42/88] netfilter: x_tables: do compat validation via
 translate_table

On Tue, Jul 19, 2016 at 11:13:12AM +0200, Florian Westphal wrote:
> Florian Westphal <fw@...len.de> wrote:
> > Michal Kubecek <mkubecek@...e.cz> wrote:
> > > > -	/* And one copy for every other CPU */
> > > > -	for_each_possible_cpu(i)
> > > > -		if (newinfo->entries[i] && newinfo->entries[i] != entry1)
> > > > -			memcpy(newinfo->entries[i], entry1, newinfo->size);
> > > 
> > > These four lines should be preserved, IMHO, as 3.12 doesn't have commit
> > > 482cfc318559 ("netfilter: xtables: avoid percpu ruleset duplication")
> > > (introduced in 4.2) which removed the need for per-cpu copies.
> > > 
> > > The same applies to the other two instances of translate_compat_table()
> > > in net/ipv4/netfilter/ip_tables.c and net/ipv6/netfilter/ip6_tables.c
> > > 
> > > Florian, do you agree?
> > 
> > Sorry, I have to look at this in more detail.
> > The patches change the compat translation version into a preprocessing
> > step rather than a 1:1 replacement of translate_table.
> > 
> > From first glance the removal is thus ok.
> 
> Removal is correct, the expanded ruleset is passed to
> translate_table() which will do the percpu duplication as last step.
> 
> [ I looked at 3.14.y tree which also dropped these lines in the backport ]

You are right, I didn't notice that. Thanks for the clarification.
I'll send v2 of the patch for 4.1 stable in a moment.

Michal Kubecek