linux-kernel - Re: [PATCH v2] arm/perf: Convert to hotplug state machine

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160719095740.GA27022@leverpostej>
Date:	Tue, 19 Jul 2016 10:57:40 +0100
From:	Mark Rutland <mark.rutland@....com>
To:	Sebastian Andrzej Siewior <bigeasy@...utronix.de>
Cc:	Ingo Molnar <mingo@...nel.org>, anna-maria@...utronix.de,
	tglx@...utronix.de, hpa@...or.com, torvalds@...ux-foundation.org,
	will.deacon@....com, peterz@...radead.org,
	linux-kernel@...r.kernel.org, linux-tip-commits@...r.kernel.org
Subject: Re: [PATCH v2] arm/perf: Convert to hotplug state machine

Hi,

On Tue, Jul 19, 2016 at 11:02:29AM +0200, Sebastian Andrzej Siewior wrote:
> +static int arm_pmu_hp_init(void)
> +{
> +	int ret;
> +
> +	ret = cpuhp_setup_state_nocalls(CPUHP_AP_PERF_ARM_STARTING,
> +					"AP_PERF_ARM_STARTING",
> +					arm_perf_starting_cpu, NULL);
> +	if (ret)
> +		pr_err("CPU hotplug notifier for ARM PMU could not be "
> +		       "registered: %d\n", ret);

Nit: Per Documentation/CodingStyle strings should always be on one line,
even if greater than 80 chars, so they're greppable. I assume that can
be fixed up when this is picked.

Otherwise, v2 looks correct to me. FWIW:

Acked-by: Mark Rutland <mark.rutland@....com>

Thanks,
Mark.