linux-kernel - Re: [PATCH] checkpatch: Yet another commit id improvement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1468922756.1900.51.camel@perches.com>
Date:	Tue, 19 Jul 2016 03:05:56 -0700
From:	Joe Perches <joe@...ches.com>
To:	Andy Whitcroft <apw@...onical.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	"Zhuo, Qiuxu" <qiuxu.zhuo@...el.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] checkpatch: Yet another commit id improvement

On Tue, 2016-07-19 at 10:51 +0100, Andy Whitcroft wrote:
> On Mon, Jul 18, 2016 at 12:27:42PM -0700, Joe Perches wrote:
> > 
> > Using \b isn't good enough to isolate what appears to be a
> > commit id in a commit message.
> > 
> > Make sure there is a space or a quote like character after
> > a continuous run of hexadecimal characters that could be
> > a commit id.
[]
> > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> > @@ -2460,9 +2460,9 @@ sub process {
> >  
> >  # Check for git id commit length and improperly formed commit descriptions
> >  		if ($in_commit_log && !$commit_log_possible_stack_dump &&
> > -		    $line !~ /^\s*(?:Link|Patchwork|http|BugLink):/i &&
> > +		    $line !~ /^\s*(?:Link|Patchwork|http|https|BugLink):/i &&
> >  		    ($line =~ /\bcommit\s+[0-9a-f]{5,}\b/i ||
> > -		     ($line =~ /\b[0-9a-f]{12,40}\b/i &&
> > +		     ($line =~ /(?:\s|^)[0-9a-f]{12,40}(?:[\s"'\(\[]|$)/i &&
> If we expect a quote after would it be unreasonable to allow then at the
> beginning too?

Perhaps not.  The idea is the quote starts the commit description
not ends the commit SHA-1 hash.