linux-kernel - Re: [PATCH]time: Optimize nohz idle enter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.11.1607191243230.3596@nanos>
Date:	Tue, 19 Jul 2016 12:45:58 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	"Gaurav Jindal (Gaurav Jindal)" <Gaurav.Jindal@...eadtrum.com>
cc:	"Sanjeev Yadav (Sanjeev Kumar Yadav)" <Sanjeev.Yadav@...eadtrum.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH]time: Optimize nohz idle enter

On Tue, 19 Jul 2016, Gaurav Jindal (Gaurav Jindal) wrote:
> On Tue, Jul 19, 2016 at 10:47:37AM +0200, Thomas Gleixner wrote:
> > On Thu, 14 Jul 2016, Gaurav Jindal (Gaurav Jindal) wrote:
> > > 
> > > tick_nohz_start_idle is called before checking the condition if the idle tick
> > > can be stopped. In case when can_stop_idle_tick returns 0, the function called
> > > is of no use thus a extra call doing nothing.
> > > 
> > > Shifting calling of function tick_nohz_start_idle inside the if condition makes
> > > sure that corresponding operations are done only if idle tick can be actually
> > > stopped. Observance for 1 minute on arm64 architecture shows that shifting code
> > > can prevent 1.5% of extra calls thus optimizing the idle call sequence.
> > 
> > Nice.
> > 
> > > Signed-off-by: gaurav jindal<gaurav.jindal@...eadtrum.com>
> > > Signed-off-by: sanjeev yadav<sanjeev.yadav@...eadtrum.com>
> > 
> > This SOB chain is wrong. Sanjeev did not send the patch and is not the
> > author. Please clarify.
> >
> Actually Sanjeev and me worked together, but since only one send the mail so I
> included his name as SOB.

That does not make it more correct. See Documentation/SubmittingPatches. I
fixed it up.

Thanks,

	tglx