linux-kernel - [PATCH resend] intel_rapl: downgrade message if no RAPL domains found in a VM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 19 Jul 2016 13:49:57 +0200
From:	Paolo Bonzini <pbonzini@...hat.com>
To:	linux-kernel@...r.kernel.org
Cc:	Thomas Renninger <trenn@...e.de>,
	Peter Zijlstra <peterz@...radead.org>, rjw@...ysocki.net,
	linux-pm@...r.kernel.org,
	Jacob Pan <jacob.jun.pan@...ux.intel.com>,
	Andy Lutomirski <luto@...capital.net>
Subject: [PATCH resend] intel_rapl: downgrade message if no RAPL domains found in a VM

People complain about the driver saying there's no valid RAPL domains
in a VM, and doing so at KERN_ERR severity.  Downgrade this to KERN_INFO
if running on a hypervisor, since it is basically stating the obvious.

Suggested-by: Peter Zijlstra <peterz@...radead.org>
Cc: Jacob Pan <jacob.jun.pan@...ux.intel.com>
Cc: Andy Lutomirski <luto@...capital.net>
Signed-off-by: Paolo Bonzini <pbonzini@...hat.com>
---
	First sent out about a year ago. :)

 drivers/powercap/intel_rapl.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/powercap/intel_rapl.c b/drivers/powercap/intel_rapl.c
index b2766b867b0e..0a0b09910116 100644
--- a/drivers/powercap/intel_rapl.c
+++ b/drivers/powercap/intel_rapl.c
@@ -1392,7 +1392,9 @@ static int rapl_detect_domains(struct rapl_package *rp, int cpu)
 	}
 	rp->nr_domains = bitmap_weight(&rp->domain_map,	RAPL_DOMAIN_MAX);
 	if (!rp->nr_domains) {
-		pr_err("no valid rapl domains found in package %d\n", rp->id);
+		printk("%sNo valid RAPL domains found in package %d\n",
+		       boot_cpu_has(X86_FEATURE_HYPERVISOR) ? KERN_INFO : KERN_ERR,
+		       rp->id);
 		ret = -ENODEV;
 		goto done;
 	}
-- 
2.7.4