linux-kernel - Re: [PATCH -next] drm/amdgpu: use list_move instead of list_del/list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <578E1842.2090802@amd.com>
Date:	Tue, 19 Jul 2016 14:08:34 +0200
From:	Christian König <christian.koenig@....com>
To:	Wei Yongjun <weiyj_lk@....com>,
	Alex Deucher <alexander.deucher@....com>, <airlied@...ux.ie>,
	<David1.Zhou@....com>, <Jammy.Zhou@....com>, <Monk.Liu@....com>
CC:	Wei Yongjun <yongjun_wei@...ndmicro.com.cn>,
	<dri-devel@...ts.freedesktop.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] drm/amdgpu: use list_move instead of
 list_del/list_add

Am 19.07.2016 um 14:01 schrieb Wei Yongjun:
> From: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
>
> Using list_move() instead of list_del() + list_add().
>
> Signed-off-by: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
Reviewed-by: Christian König <christian.koenig@....com>

> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
> index 0307ff5..aba38ec 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
> @@ -414,8 +414,7 @@ static int amdgpu_cs_parser_bos(struct amdgpu_cs_parser *p,
>   
>   			if (e->robj->tbo.ttm->state != tt_bound &&
>   			    !e->user_pages) {
> -				list_del(&e->tv.head);
> -				list_add(&e->tv.head, &need_pages);
> +				list_move(&e->tv.head, &need_pages);
>   
>   				amdgpu_bo_unreserve(e->robj);
>   			}
>
>
>
>