linux-kernel - Re: [PATCH v2 1/2] rtc: s3c: Remove unnecessary call to disable already disabled clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160719155002.GK7132@piout.net>
Date:	Tue, 19 Jul 2016 17:50:02 +0200
From:	Alexandre Belloni <alexandre.belloni@...e-electrons.com>
To:	Alim Akhtar <alim.akhtar@...sung.com>
Cc:	rtc-linux@...glegroups.com, linux-kernel@...r.kernel.org,
	k.kozlowski@...sung.com, javier@....samsung.com,
	pankaj.dubey@...sung.com
Subject: Re: [PATCH v2 1/2] rtc: s3c: Remove unnecessary call to disable
 already disabled clock

On 05/07/2016 at 15:28:52 +0530, Alim Akhtar wrote :
> At the end of s3c_rtc_probe(), s3c_rtc_disable_clk() being called with rtc
> clock already disabled (by s3c_rtc_gettime()), which looks extra and
> unnecessary call. Lets clean it up.
> 
> Signed-off-by: Alim Akhtar <alim.akhtar@...sung.com>
> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@...sung.com>
> Reviewed-by: Pankaj Dubey <pankaj.dubey@...sung.com>
> Tested-by: Pankaj Dubey <pankaj.dubey@...sung.com>
> ---
>  drivers/rtc/rtc-s3c.c |    2 --
>  1 file changed, 2 deletions(-)
> 
Applied, thanks.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com