linux-kernel - Re: [PATCH v3 1/4] lib/dlock-list: Distributed and lock-protected lists

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <578E790A.6090403@hpe.com>
Date:	Tue, 19 Jul 2016 15:01:30 -0400
From:	Waiman Long <waiman.long@....com>
To:	Al Viro <viro@...IV.linux.org.uk>
CC:	Jan Kara <jack@...e.com>, Jeff Layton <jlayton@...chiereds.net>,
	"J. Bruce Fields" <bfields@...ldses.org>,
	Tejun Heo <tj@...nel.org>,
	Christoph Lameter <cl@...ux-foundation.org>,
	<linux-fsdevel@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	Ingo Molnar <mingo@...hat.com>,
	Peter Zijlstra <peterz@...radead.org>,
	Andi Kleen <andi@...stfloor.org>,
	Dave Chinner <dchinner@...hat.com>,
	Boqun Feng <boqun.feng@...il.com>,
	Scott J Norton <scott.norton@....com>,
	Douglas Hatch <doug.hatch@....com>
Subject: Re: [PATCH v3 1/4] lib/dlock-list: Distributed and lock-protected
 lists

On 07/19/2016 01:00 AM, Al Viro wrote:
> On Fri, Jul 15, 2016 at 01:39:40PM -0400, Waiman Long wrote:
>
>> +struct dlock_list_head_percpu {
>> +	struct list_head list;
>> +	spinlock_t lock;
>> +};
>> +#define DLOCK_LIST_HEAD_PERCPU_INIT(name)			\
>> +	{							\
>> +		.list.prev =&name.list,			\
>> +		.list.next =&name.list,			\
>> +		.list.lock = __SPIN_LOCK_UNLOCKED(name),	\
> What's .list.lock and how does that even compile?

Yes, it is a typo. This macro is not used. That is why there is no 
compilation error. I will remove it from the patch.

>> +extern bool dlock_list_next(struct dlock_list_head *dlist,
>> +			    struct dlock_list_iter *iter);
> Ugh...  Why not dlist_for_each_entry(), seeing that all users end up with
> the same boilerplate?

Right, I could make a dlock_list_for_each_entry() that encapsulate the 
boilerplate. I will work on that.

Thanks,
Longman