linux-kernel - Re: [PATCH] acpi: make dock explicitly non-modular

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <17088439.Xyg2UnmaAy@vostro.rjw.lan>
Date:	Tue, 19 Jul 2016 22:09:04 +0200
From:	"Rafael J. Wysocki" <rjw@...ysocki.net>
To:	Paul Gortmaker <paul.gortmaker@...driver.com>
Cc:	linux-kernel@...r.kernel.org, Len Brown <lenb@...nel.org>,
	linux-acpi@...r.kernel.org
Subject: Re: [PATCH] acpi: make dock explicitly non-modular

On Monday, July 11, 2016 04:23:26 PM Paul Gortmaker wrote:
> The Kconfig for this file is:
> 
> drivers/acpi/Kconfig:config ACPI_DOCK
> drivers/acpi/Kconfig:   bool "Dock"
> 
> ...and so it is not built as a module.  Hence including module.h
> and everything that comes with it just for the no-op MODULE_LICENSE
> and friends is rather heavy handed.
> 
> The license/author info is found at the top of the file, so we
> just remove the MODULE_LICENSE etc and the include of module.h
> 
> The file does still have some module_param() so we add the right
> include for that infrastructure.
> 
> Cc: "Rafael J. Wysocki" <rjw@...ysocki.net>
> Cc: Len Brown <lenb@...nel.org>
> Cc: linux-acpi@...r.kernel.org
> Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com>

Applied, thanks!