linux-kernel - Re: [PATCH v3 0/5] Use tpm_transmit_cmd() consistently across kernel call sites

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160719202841.GC16042@obsidianresearch.com>
Date:	Tue, 19 Jul 2016 14:28:41 -0600
From:	Jason Gunthorpe <jgunthorpe@...idianresearch.com>
To:	Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
Cc:	Peter Huewe <peterhuewe@....de>,
	linux-security-module@...r.kernel.org,
	Stefan Berger <stefanb@...ux.vnet.ibm.com>,
	open list <linux-kernel@...r.kernel.org>,
	"moderated list:TPM DEVICE DRIVER" 
	<tpmdd-devel@...ts.sourceforge.net>
Subject: Re: [PATCH v3 0/5] Use tpm_transmit_cmd() consistently across kernel
 call sites

On Tue, Jul 19, 2016 at 04:32:44PM +0300, Jarkko Sakkinen wrote:
> These commits update the subsystem consistently to use
> tpm_transmit_cmd() throughout the subsystem the exception being
> tpm_write() where it makes sense to use the raw interface because higher
> level command handling is delegated to user space. The point is to make
> semantics and error handling across the kernel call sites.
> 
> v3: Removed patch that renames tpm_pcr_read_dev() to tpm1_pcr_read()
> because it is not mandatory for this patch set.
> 
> v2: Added commit that drops externs from all function declarations in
> tpm.h as suggested by Jason Gunthorpe.

Other than my comment:

Reviewed-by: Jason Gunthorpe <jgunthorpe@...idianresearch.com>

Jason