linux-kernel - Re: [PATCH v2] checkpatch: don't complain about BIT macro in uapi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1468965197.1900.78.camel@perches.com>
Date:	Tue, 19 Jul 2016 14:53:17 -0700
From:	Joe Perches <joe@...ches.com>
To:	Tomas Winkler <tomas.winkler@...el.com>,
	Andy Whitcroft <apw@...onical.com>
Cc:	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH v2] checkpatch: don't complain about BIT macro in uapi

On Sun, 2016-07-17 at 01:10 +0300, Tomas Winkler wrote:
> BIT macro cannot be exported to UAPI, don't complain about it
> 
> Signed-off-by: Tomas Winkler <tomas.winkler@...el.com>

Acked-by: Joe Perches <joe@...ches.com>


Andrew, can you please pick this up?
> ---
> V2: fix indentation
>  scripts/checkpatch.pl | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index a0e511206f24..76d3fccb82f3 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -5733,8 +5733,9 @@ sub process {
>  			}
>  		}
>  
> -# check for #defines like: 1 <<  that could be BIT(digit)
> -		if ($line =~ /#\s*define\s+\w+\s+\(?\s*1\s*([ulUL]*)\s*\<\<\s*(?:\d+|$Ident)\s*\)?/) {
> +# check for #defines like: 1 <<  that could be BIT(digit), it is not exported to uapi
> +		if ($realfile !~ m@...clude/uapi/@ &&
> +		    $line =~ /#\s*define\s+\w+\s+\(?\s*1\s*([ulUL]*)\s*\<\<\s*(?:\d+|$Ident)\s*\)?/) {
>  			my $ull = "";
>  			$ull = "_ULL" if (defined($1) && $1 =~ /ll/i);
>  			if (CHK("BIT_MACRO",