linux-kernel - Re: [kbuild-all] [PATCH v17 net-next 1/1] hv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160720030619.GA26466@wfg-t540p.sh.intel.com>
Date:	Wed, 20 Jul 2016 11:06:19 +0800
From:	Fengguang Wu <lkp@...el.com>
To:	David Miller <davem@...emloft.net>
Cc:	decui@...rosoft.com, mkubecek@...e.cz, olaf@...fle.de,
	gregkh@...uxfoundation.org, jasowang@...hat.com,
	dave.scott@...ker.com, linux-kernel@...r.kernel.org,
	joe@...ches.com, rolf.neugebauer@...ker.com, kbuild-all@...org,
	netdev@...r.kernel.org, apw@...onical.com,
	devel@...uxdriverproject.org, vkuznets@...hat.com,
	kys@...rosoft.com, cavery@...hat.com, haiyangz@...rosoft.com
Subject: Re: [kbuild-all] [PATCH v17 net-next 1/1] hv_sock: introduce Hyper-V
 Sockets

On Tue, Jul 19, 2016 at 07:52:53PM -0700, David Miller wrote:
>From: Dexuan Cui <decui@...rosoft.com>
>Date: Wed, 20 Jul 2016 01:48:18 +0000
>
>>> From: kbuild test robot [mailto:lkp@...el.com]
>>> Sent: Wednesday, July 20, 2016 1:10
>>>
>>> Hi,
>>>
>>> [auto build test WARNING on net-next/master]
>>>
>>> url:    https://github.com/0day-ci/linux/commits/Dexuan-Cui/introduce-
>>> Hyper-V-VM-Sockets-hv_sock/20160715-223433
>>> config: x86_64-randconfig-a0-07191719 (attached as .config)
>>> compiler: gcc-4.4 (Debian 4.4.7-8) 4.4.7
>>> reproduce:
>>>         # save the attached .config to linux build tree
>>>         make ARCH=x86_64
>>>
>>> All warnings (new ones prefixed by >>):
>>>
>>>    net/hv_sock/af_hvsock.c: In function 'hvsock_open_connection':
>>>    net/hv_sock/af_hvsock.c:693: warning: 'hvsk' may be used uninitialized in
>>> this function
>>>    net/hv_sock/af_hvsock.c:693: warning: 'new_hvsk' may be used
>>> uninitialized in this function
>>>    net/hv_sock/af_hvsock.c:697: warning: 'new_sk' may be used uninitialized
>>> in this function
>>>    net/hv_sock/af_hvsock.c: In function 'hvsock_sendmsg_wait':
>>>    net/hv_sock/af_hvsock.c:1053: warning: 'ret' may be used uninitialized in
>>> this function
>>> >> net/hv_sock/af_hvsock.o: warning: objtool: hvsock_on_channel_cb()+0x1d:
>>> function has unreachable instruction
>>
>> These warnings are all false alarms.
>
>But you still have to quiet them.

Agreed.

However the last warning

        objtool: hvsock_on_channel_cb()+0x1d: function has unreachable instruction

is my fault -- it turns out to be a problem with old gcc-4.4 and
gcc-4.6 which we enabled 2 days ago. I just disabled reporting this
odd warning because it complaints on ~10000 functions all over the
place, which can only be sanely fixed in the toolchain.

Thanks,
Fengguang