linux-kernel - Re: [RFC][PATCH 07/10 v2] ASoC: hisilicon: Add hi6210 i2s audio driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160720002835.GC6509@sirena.org.uk>
Date:	Wed, 20 Jul 2016 01:28:35 +0100
From:	Mark Brown <broonie@...nel.org>
To:	John Stultz <john.stultz@...aro.org>
Cc:	lkml <linux-kernel@...r.kernel.org>,
	Andy Green <andy.green@...aro.org>,
	Zhangfei Gao <zhangfei.gao@...aro.org>,
	Jingoo Han <jg1.han@...sung.com>,
	Krzysztof Kozlowski <k.kozlowski@...sung.com>,
	Maxime Ripard <maxime.ripard@...e-electrons.com>,
	Vinod Koul <vinod.koul@...el.com>,
	Dan Williams <dan.j.williams@...el.com>,
	Liam Girdwood <lgirdwood@...il.com>,
	Jaroslav Kysela <perex@...ex.cz>,
	Takashi Iwai <tiwai@...e.com>, Wei Xu <xuwei5@...ilicon.com>,
	Rob Herring <robh+dt@...nel.org>, Andy Green <andy@...mcat.com>
Subject: Re: [RFC][PATCH 07/10 v2] ASoC: hisilicon: Add hi6210 i2s audio
 driver

On Tue, Jul 19, 2016 at 04:22:43PM -0700, John Stultz wrote:

>  sound/soc/Kconfig                |   1 +
>  sound/soc/Makefile               |   1 +
>  sound/soc/hisilicon/Kconfig      |   5 +
>  sound/soc/hisilicon/Makefile     |   1 +
>  sound/soc/hisilicon/hi6210-i2s.c | 678 +++++++++++++++++++++++++++++++++++++++
>  sound/soc/hisilicon/hi6210-i2s.h | 276 ++++++++++++++++
>  6 files changed, 962 insertions(+)

This is adding a new binding without documenting it and still looks like
it's far more than an I2S controller.

> +	switch (params_rate(params)) {
> +	default:
> +		dev_err(cpu_dai->dev, "Bad rate\n");
> +		return -EINVAL;

We should tell the user what rate.

> +	if (bits == HII2S_BITS_24) {
> +		i2s->bits = 32;
> +		dma_data->addr_width = 3;
> +	} else {
> +		i2s->bits = 16;
> +		dma_data->addr_width = 2;
> +	}

This looks like it should be a switch statement, there's some similar
stuff for the channels.

> +	_hi6210_i2s_set_fmt(i2s, substream);

Why is this not in line given that this is the only user?

> +	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> +	if (!res) {
> +		ret = -ENODEV;
> +		goto err2;
> +	}
> +
> +	i2s->base = devm_ioremap_resource(dev, res);

devm_ioremap_resource() will check the error.

> +err3:
> +	while (--i2s->clocks)
> +		clk_put(i2s->clk[i2s->clocks]);
> +
> +err2:
> +	kfree(i2s);

You switched to using devm_ but left the error handling.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)