linux-kernel - RE: [PATCH v5 4/8] char: rpmb: provide a user space interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5B8DA87D05A7694D9FA63FD143655C1B54297958@hasmsx108.ger.corp.intel.com>
Date:	Wed, 20 Jul 2016 09:02:49 +0000
From:	"Winkler, Tomas" <tomas.winkler@...el.com>
To:	"Gortmaker, Paul (Wind River)" <paul.gortmaker@...driver.com>
CC:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Ulf Hansson <ulf.hansson@...aro.org>,
	"Hunter, Adrian" <adrian.hunter@...el.com>,
	"James Bottomley" <James.Bottomley@...senpartnership.com>,
	"Martin K. Petersen" <martin.petersen@...cle.com>,
	Vinayak Holikatti <vinholikatti@...il.com>,
	Andy Lutomirski <luto@...nel.org>,
	Arve Hj?nnev?g <arve@...roid.com>,
	"Michael Ryleev" <gmar@...gle.com>,
	Joao Pinto <Joao.Pinto@...opsys.com>,
	"Christoph Hellwig" <hch@....de>,
	Yaniv Gardi <ygardi@...eaurora.org>,
	LKML <linux-kernel@...r.kernel.org>,
	"linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
	"linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>
Subject: RE: [PATCH v5 4/8] char: rpmb: provide a user space interface

> 
> On Mon, Jul 18, 2016 at 4:27 PM, Tomas Winkler <tomas.winkler@...el.com>
> wrote:
> > The user space API is achieved via two synchronous IOCTL.
> > Simplified one, RPMB_IOC_REQ_CMD, were read result cycles is
> performed
> > by the framework on behalf the user and second, RPMB_IOC_SEQ_CMD
> where
> > the whole RPMB sequence including RESULT_READ is supplied by the caller.
> > The latter is intended for  easier adjusting  of the  applications
> > that use MMC_IOC_MULTI_CMD ioctl.
> >
> > Signed-off-by: Tomas Winkler <tomas.winkler@...el.com>
> > ---
> 
> [...]
> 
> > diff --git a/drivers/char/rpmb/Kconfig b/drivers/char/rpmb/Kconfig
> > index c5e6e909efce..6794be9fcc5e 100644
> > --- a/drivers/char/rpmb/Kconfig
> > +++ b/drivers/char/rpmb/Kconfig
> > @@ -6,3 +6,10 @@ config RPMB
> >           access RPMB partition.
> >
> >           If unsure, select N.
> > +
> > +config RPMB_INTF_DEV
> > +       bool "RPMB character device interface /dev/rpmbN"
> 
> A bool Kconfig should ideally....
> 
> > +       depends on RPMB
> > +       help
> > +         Say yes here if you want to access RPMB from user space
> > +         via character device interface /dev/rpmb%d
> > diff --git a/drivers/char/rpmb/Makefile b/drivers/char/rpmb/Makefile
> > index 812b3ed264c0..b5dc087b1299 100644
> > --- a/drivers/char/rpmb/Makefile
> > +++ b/drivers/char/rpmb/Makefile
> > @@ -1,4 +1,5 @@
> >  obj-$(CONFIG_RPMB) += rpmb.o
> >  rpmb-objs += core.o
> > +rpmb-$(CONFIG_RPMB_INTF_DEV) += cdev.o

This is not a builtin, this is an optional part of the module 

> > +#include <linux/module.h>
> 
> ....not use module.h or any MODULE_ macros from within it.

Can be dropped in this case as no macros are used, 
but the pattern Kconfig bool -> no include module.h  you are following has false positive cases.

Thanks
Tomas