linux-kernel - [PATCH] hwmon: ftsteutates: add watchdog dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160720103809.2643157-1-arnd@arndb.de>
Date:	Wed, 20 Jul 2016 12:37:42 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	Jean Delvare <jdelvare@...e.com>,
	Guenter Roeck <linux@...ck-us.net>
Cc:	Arnd Bergmann <arnd@...db.de>, Thilo Cestonaro <thilo@...tona.ro>,
	linux-hwmon@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH] hwmon: ftsteutates: add watchdog dependency

The newly added fts "Teutates" hwmon chip contains a watchdog but fails
to link when the watchdog subsystem is disabled:

drivers/hwmon/built-in.o: In function `fts_remove':
:(.text+0x161d8): undefined reference to `watchdog_unregister_device'
drivers/hwmon/built-in.o: In function `fts_probe':
:(.text+0x16cb4): undefined reference to `watchdog_register_device'

This adds a Kconfig dependency in the same way that the other
similar drivers have.

Signed-off-by: Arnd Bergmann <arnd@...db.de>
Fixes: ec9268ba1a96 ("hwmon: Add driver for FTS BMC chip "Teutates"")
---
 drivers/hwmon/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
index 15479eb15fa2..eaf2f916d48c 100644
--- a/drivers/hwmon/Kconfig
+++ b/drivers/hwmon/Kconfig
@@ -488,7 +488,8 @@ config SENSORS_FSCHMD
 
 config SENSORS_FTSTEUTATES
 	tristate "Fujitsu Technology Solutions sensor chip Teutates"
-	depends on I2C
+	depends on I2C && WATCHDOG
+	select WATCHDOG_CORE
 	help
 	  If you say yes here you get support for the Fujitsu Technology
 	  Solutions (FTS) sensor chip "Teutates" including support for
-- 
2.9.0