linux-kernel - Re: [PATCH] gpio: tegra: don't auto-enable for COMPILE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160720104148.GA5362@gmail.com>
Date:	Wed, 20 Jul 2016 12:41:48 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	Linus Walleij <linus.walleij@...aro.org>
Cc:	Arnd Bergmann <arnd@...db.de>,
	Alexandre Courbot <gnurou@...il.com>,
	Alexander Stein <alexanders83@....de>,
	William Breathitt Gray <vilhelm.gray@...il.com>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] gpio: tegra: don't auto-enable for COMPILE_TEST


* Linus Walleij <linus.walleij@...aro.org> wrote:

> On Wed, Jul 6, 2016 at 2:54 PM, Arnd Bergmann <arnd@...db.de> wrote:
> 
> > I stumbled over a build error with COMPILE_TEST and CONFIG_OF
> > disabled:
> >
> > drivers/gpio/gpio-tegra.c: In function 'tegra_gpio_probe':
> > drivers/gpio/gpio-tegra.c:603:9: error: 'struct gpio_chip' has no member named 'of_node'
> >
> > The problem is that the newly added GPIO_TEGRA Kconfig symbol
> > does not have a dependency on CONFIG_OF. However, there is another
> > problem here as the driver gets enabled unconditionally whenever
> > COMPILE_TEST is set.
> >
> > This fixes both problems, by making the symbol user-visible
> > when COMPILE_TEST is set and default-enabled for ARCH_TEGRA=y.
> >
> > As a side-effect, it is now possible to compile-test a Tegra
> > kernel with GPIO support disabled, which is harmless.
> >
> > Signed-off-by: Arnd Bergmann <arnd@...db.de>
> > Fixes: 4dd4dd1d2120 ("gpio: tegra: Allow compile test")
> 
> Patch applied.

This is still not upstream and this build failure is very prominent in the 
upstream kernel right now.

> I'm starting to get a bit tired about anything related to compile testing.

They are very useful in finding real problems as well, and some people
(like me! :-) rely on being able to generate random kernel images and
 boot them.

Thanks,

	Ingo