linux-kernel - Re: [PATCH v11 4/5] powerpc/fsl: move mpc85xx.h to include/linux/fsl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4016699.uYaV8nWfqC@wuerfel>
Date:	Wed, 20 Jul 2016 13:24:00 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	Scott Wood <oss@...error.net>
Cc:	linuxppc-dev@...ts.ozlabs.org, Yangbo Lu <yangbo.lu@....com>,
	linux-mmc@...r.kernel.org, linux-kernel@...r.kernel.org,
	devicetree@...r.kernel.org
Subject: Re: [PATCH v11 4/5] powerpc/fsl: move mpc85xx.h to include/linux/fsl

On Saturday, July 16, 2016 9:50:21 PM CEST Scott Wood wrote:
> From: yangbo lu <yangbo.lu@....com>
> 
> Move mpc85xx.h to include/linux/fsl and rename it to svr.h as a common
> header file.  This SVR numberspace is used on some ARM chips as well as
> PPC, and even to check for a PPC SVR multi-arch drivers would otherwise
> need to ifdef the header inclusion and all references to the SVR symbols.
> 
> Signed-off-by: Yangbo Lu <yangbo.lu@....com>
> Acked-by: Wolfram Sang <wsa@...-dreams.de>
> Acked-by: Stephen Boyd <sboyd@...eaurora.org>
> Acked-by: Joerg Roedel <jroedel@...e.de>
> [scottwood: update description]
> Signed-off-by: Scott Wood <oss@...error.net>
> 

As discussed before, please don't introduce yet another vendor specific
way to match a SoC ID from a device driver.

I've posted a patch for an extension to the soc_device infrastructure
to allow comparing the running SoC to a table of devices, use that
instead.

	Arnd