linux-kernel - Re: [PATCH] SRAM: Delete an unnecessary check before the function call "of_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cc5d5494-9454-86ca-a351-1627ace4e241@users.sourceforge.net>
Date:	Wed, 20 Jul 2016 14:34:45 +0200
From:	SF Markus Elfring <elfring@...rs.sourceforge.net>
To:	linux-kernel@...r.kernel.org, Arnd Bergmann <arnd@...db.de>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:	kernel-janitors@...r.kernel.org,
	Julia Lawall <julia.lawall@...6.fr>
Subject: Re: [PATCH] SRAM: Delete an unnecessary check before the function
 call "of_node_put"

> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Fri, 6 Nov 2015 10:36:49 +0100
> 
> The of_node_put() function tests whether its argument is NULL and then
> returns immediately. Thus the test around the call is not needed.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
> ---
>  drivers/misc/sram.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/misc/sram.c b/drivers/misc/sram.c
> index 736dae7..34287f7 100644
> --- a/drivers/misc/sram.c
> +++ b/drivers/misc/sram.c
> @@ -326,9 +326,7 @@ static int sram_reserve_regions(struct sram_dev *sram, struct resource *res)
>  	}
>  
>   err_chunks:
> -	if (child)
> -		of_node_put(child);
> -
> +	of_node_put(child);
>  	kfree(rblocks);
>  
>  	return ret;
> 

How do you think about to integrate this update suggestion
into another source code repository?

Regards,
Markus