[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20160720130356.GB7976@valkosipuli.retiisi.org.uk>
Date: Wed, 20 Jul 2016 16:03:57 +0300
From: Sakari Ailus <sakari.ailus@....fi>
To: Javier Martinez Canillas <javier@....samsung.com>
Cc: linux-kernel@...r.kernel.org,
Marek Szyprowski <m.szyprowski@...sung.com>,
Mauro Carvalho Chehab <mchehab@...pensource.com>,
Kyungmin Park <kyungmin.park@...sung.com>,
Pawel Osciak <pawel@...iak.com>, linux-media@...r.kernel.org
Subject: Re: [PATCH] [media] vb2: include length in dmabuf qbuf debug message
Hi Javier,
Thanks for the patch!
On Thu, Jul 14, 2016 at 11:09:34AM -0400, Javier Martinez Canillas wrote:
> If the the VIDIOC_QBUF ioctl fails due a wrong dmabuf length,
> it's useful to get the invalid length as a debug information.
>
> Before this patch:
>
> vb2-core: __qbuf_dmabuf: invalid dmabuf length for plane 1
>
> After this patch:
>
> vb2-core: __qbuf_dmabuf: invalid dmabuf length 221248 for plane 1
>
> Signed-off-by: Javier Martinez Canillas <javier@....samsung.com>
>
> ---
>
> drivers/media/v4l2-core/videobuf2-core.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/v4l2-core/videobuf2-core.c b/drivers/media/v4l2-core/videobuf2-core.c
> index ca8ffeb56d72..97d1483e0f7a 100644
> --- a/drivers/media/v4l2-core/videobuf2-core.c
> +++ b/drivers/media/v4l2-core/videobuf2-core.c
> @@ -1228,8 +1228,8 @@ static int __qbuf_dmabuf(struct vb2_buffer *vb, const void *pb)
> planes[plane].length = dbuf->size;
>
> if (planes[plane].length < vb->planes[plane].min_length) {
> - dprintk(1, "invalid dmabuf length for plane %d\n",
> - plane);
> + dprintk(1, "invalid dmabuf length %d for plane %d\n",
%u, please. You might want to print the minimum length as well.
> + planes[plane].length, plane);
> dma_buf_put(dbuf);
> ret = -EINVAL;
> goto err;
--
Kind regards,
Sakari Ailus
e-mail: sakari.ailus@....fi XMPP: sailus@...iisi.org.uk
Powered by blists - more mailing lists