linux-kernel - Re: [PATCH] radix-tree: fix comment about "exceptional" bits

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160720131038.w5ouqmyd3kvrfc2s@c203.arch.suse.de>
Date:	Wed, 20 Jul 2016 15:10:38 +0200
From:	Johannes Thumshirn <jthumshirn@...e.de>
To:	Ross Zwisler <ross.zwisler@...ux.intel.com>
Cc:	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-nvdimm@...ts.01.org, Dave Chinner <david@...morbit.com>,
	Jan Kara <jack@...e.com>,
	Konstantin Khlebnikov <koct9i@...il.com>
Subject: Re: [PATCH] radix-tree: fix comment about "exceptional" bits

On Wed, Jul 20, 2016 at 12:55:31AM -0600, Ross Zwisler wrote:
> The bottom two bits of radix tree entries are reserved for special use by
> the radix tree code itself.  A comment detailing their usage was added by:
> 
> commit 3bcadd6fa6c4 ("radix-tree: free up the bottom bit of exceptional
> entries for reuse")
> 
> This comment states that if the bottom two bits are '11', this means that
> this is a locked exceptional entry.
> 
> It turns out that this bit combination was never actually used.  Radix tree
> locking for DAX was indeed implemented, but it actually used the third LSB:
> 
>   /* We use lowest available exceptional entry bit for locking */
>   #define RADIX_DAX_ENTRY_LOCK (1 << RADIX_TREE_EXCEPTIONAL_SHIFT)
> 
> This locking code was also made specific to the DAX code instead of being
> generally implemented in radix-tree.h.
> 
> So, fix the comment.
> 
> Signed-off-by: Ross Zwisler <ross.zwisler@...ux.intel.com>

Reviewed-by: Johannes Thumshirn <jthumshirn@...e.de>

-- 
Johannes Thumshirn                                          Storage
jthumshirn@...e.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850