linux-kernel - Re: [PATCH] staging: iio: light: isl29018/28: remove I2C_CLASS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0d515ff9-252a-a8f9-49c1-89ef0b1e9887@kernel.org>
Date:	Wed, 20 Jul 2016 16:08:26 +0100
From:	Jonathan Cameron <jic23@...nel.org>
To:	Wolfram Sang <wsa@...-dreams.de>
Cc:	Laxman Dewangan <ldewangan@...dia.com>,
	Alison Schofield <amsfield22@...il.com>, knaack.h@....de,
	lars@...afoo.de, pmeerw@...erw.net, linux-iio@...r.kernel.org,
	linux-kernel@...r.kernel.org, Linux I2C <linux-i2c@...r.kernel.org>
Subject: Re: [PATCH] staging: iio: light: isl29018/28: remove I2C_CLASS_HWMON
 .class setting

On 19/07/16 08:13, Wolfram Sang wrote:
> On Mon, Jul 18, 2016 at 02:30:46PM +0100, Jonathan Cameron wrote:
>> On 18/07/16 09:50, Laxman Dewangan wrote:
>>>
>>> On Saturday 16 July 2016 07:58 AM, Alison Schofield wrote:
>>>> I2C_CLASS_HWMON is for a hardware monitoring chip wanting
>>>> auto-detection.  IIO drivers don't typically use .class.
>>>> Remove it.
>>>>
>>>> Signed-off-by: Alison Schofield <amsfield22@...il.com>
>>>> Cc: Daniel Baluta <daniel.baluta@...il.com>
>>>>
>>>
>>> Agree.
>>> Acked-by: Laxman Dewangan <ldewangan@...dia.com>
>> Any resulting ABI change from dropping it?
> 
> What do you mean with ABI? This is only relevant for "automatic"
> instantiation.
Cool, I was just being paranoid and didn't have time to check!

Thanks,

Jonathan
> From me:
> 
> Acked-by: Wolfram Sang <wsa@...-dreams.de>
>