lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Wed, 20 Jul 2016 10:33:39 -0500
From:	Nishanth Menon <nm@...com>
To:	Mugunthan V N <mugunthanvnm@...com>, <netdev@...r.kernel.org>,
	Rob Herring <robh+dt@...nel.org>
CC:	Mark Rutland <mark.rutland@....com>,
	Tony Lindgren <tony@...mide.com>,
	Russell King <linux@...linux.org.uk>,
	Florian Fainelli <f.fainelli@...il.com>,
	"David S . Miller" <davem@...emloft.net>,
	Sekhar Nori <nsekhar@...com>, <devicetree@...r.kernel.org>,
	<linux-omap@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [net-next PATCH 1/3] net: phy: dp83867: Add documentation for
 optional impedance control

On 07/20/2016 09:56 AM, Mugunthan V N wrote:
> Add documention of ti,impedance-control which can be used to
> correct MAC impedance mismatch using phy extended registers.
>
> Signed-off-by: Mugunthan V N <mugunthanvnm@...com>
> ---
>   Documentation/devicetree/bindings/net/ti,dp83867.txt | 7 +++++++
>   1 file changed, 7 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/ti,dp83867.txt b/Documentation/devicetree/bindings/net/ti,dp83867.txt
> index 5d21141..531ea3c5 100644
> --- a/Documentation/devicetree/bindings/net/ti,dp83867.txt
> +++ b/Documentation/devicetree/bindings/net/ti,dp83867.txt
> @@ -9,6 +9,13 @@ Required properties:
>   	- ti,fifo-depth - Transmitt FIFO depth- see dt-bindings/net/ti-dp83867.h
>   		for applicable values
>
> +Optional property:
> +	- ti,impedance-control - MAC Interface Impedance control to vary the
> +				 output impedance with an approximate range
> +				 from 35-70 ohms in 32 steps. Value range can
> +				 be 0x0 to 0x1f. Lowest impedance value is
> +				 0x1f and highest impedance being 0x0.
> +

Should'nt you be using the impedance values of 35 to 70 as the valid 
values here? that would be the hardware description, and the values to 
program corresponding to those are 0x00 to 0x1f. Right?

Rob: is'nt that the right way to do it?

>   Default child nodes are standard Ethernet PHY device
>   nodes as described in Documentation/devicetree/bindings/net/phy.txt
>
>


-- 
Regards,
Nishanth Menon

Powered by blists - more mailing lists