linux-kernel - Re: [PATCH 6/9] staging: ks7010: Delete unnecessary braces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160720155408.GF1688@katana>
Date:	Wed, 20 Jul 2016 17:54:08 +0200
From:	Wolfram Sang <wsa@...-dreams.de>
To:	Julia Lawall <julia.lawall@...6.fr>
Cc:	SF Markus Elfring <elfring@...rs.sourceforge.net>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	devel@...verdev.osuosl.org, LKML <linux-kernel@...r.kernel.org>,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 6/9] staging: ks7010: Delete unnecessary braces

On Sun, Jul 17, 2016 at 08:55:41PM +0200, Julia Lawall wrote:
> 
> 
> On Sun, 17 Jul 2016, SF Markus Elfring wrote:
> 
> > From: Markus Elfring <elfring@...rs.sourceforge.net>
> > Date: Sun, 17 Jul 2016 18:39:03 +0200
> >
> > Do not use curly brackets at some source code places
> > where a single statement should be sufficient.
> >
> > Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
> > ---
> >  drivers/staging/ks7010/ks7010_sdio.c | 48 ++++++++++++------------------------
> >  1 file changed, 16 insertions(+), 32 deletions(-)
> >
> > diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/staging/ks7010/ks7010_sdio.c
> > index b3ca8e2..1e072e3 100644
> > --- a/drivers/staging/ks7010/ks7010_sdio.c
> > +++ b/drivers/staging/ks7010/ks7010_sdio.c
> > @@ -109,9 +109,8 @@ void ks_wlan_hw_sleep_doze_request(struct ks_wlan_private *priv)
> >  		DPRINTK(3, "sleep_mode=SLP_SLEEP\n");
> >  		atomic_set(&priv->sleepstatus.status, 1);
> >  		priv->last_doze = jiffies;
> > -	} else {
> > +	} else
> >  		DPRINTK(1, "sleep_mode=%d\n", priv->sleep_mode);
> > -	}
> 
> This is a violation of CodingStyle:

Julia is right again, I agree.


Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)