linux-kernel - Re: [PATCH v3 5/7] iscsi-target: replace iscsi_initiatorname

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 20 Jul 2016 14:16:05 -0700
From:	"Nicholas A. Bellinger" <nab@...ux-iscsi.org>
To:	Markus Mayer <mmayer@...adcom.com>
Cc:	Roland Dreier <roland@...estorage.com>,
	Varun Prakash <varun@...lsio.com>, linux-scsi@...r.kernel.org,
	target-devel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 5/7] iscsi-target: replace
 iscsi_initiatorname_tolower() with strtolower()

On Fri, 2016-07-08 at 15:43 -0700, Markus Mayer wrote:
> After introducing generic strtolower(), iscsi_initiatorname_tolower() is
> no longer needed.
> 
> Signed-off-by: Markus Mayer <mmayer@...adcom.com>
> ---
>  drivers/target/iscsi/iscsi_target_nego.c | 17 +----------------
>  1 file changed, 1 insertion(+), 16 deletions(-)
> 
> diff --git a/drivers/target/iscsi/iscsi_target_nego.c b/drivers/target/iscsi/iscsi_target_nego.c
> index 89d34bd..fa20638 100644
> --- a/drivers/target/iscsi/iscsi_target_nego.c
> +++ b/drivers/target/iscsi/iscsi_target_nego.c
> @@ -987,21 +987,6 @@ static int iscsi_target_do_login(struct iscsi_conn *conn, struct iscsi_login *lo
>  	return 0;
>  }
>  
> -static void iscsi_initiatorname_tolower(
> -	char *param_buf)
> -{
> -	char *c;
> -	u32 iqn_size = strlen(param_buf), i;
> -
> -	for (i = 0; i < iqn_size; i++) {
> -		c = &param_buf[i];
> -		if (!isupper(*c))
> -			continue;
> -
> -		*c = tolower(*c);
> -	}
> -}
> -
>  /*
>   * Processes the first Login Request..
>   */
> @@ -1075,7 +1060,7 @@ int iscsi_target_locate_portal(
>  	 * RFC-3720 3.2.6.1. section c) that says that iSCSI IQNs
>  	 * are NOT case sensitive.
>  	 */
> -	iscsi_initiatorname_tolower(i_buf);
> +	strtolower(i_buf);
>  
>  	if (!s_buf) {
>  		if (!login->leading_connection)

Applied to target-pending/for-next.

Thanks Markus.