[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAL_Jsq+JB7+63Wmvd1ApoDg=pCFV+483x9TAucNzAFr1Hzj5Ug@mail.gmail.com>
Date: Wed, 20 Jul 2016 17:40:33 -0500
From: Rob Herring <robh+dt@...nel.org>
To: Alexandre Belloni <alexandre.belloni@...e-electrons.com>
Cc: Arnaud Ebalard <arno@...isbad.org>,
Alessandro Zummo <a.zummo@...ertech.it>,
"open list:REAL TIME CLOCK (RTC) SUBSYSTEM"
<rtc-linux@...glegroups.com>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/3] Documentation: dt: Intersil isl12057 is not a trivial device
On Wed, Jul 20, 2016 at 2:32 PM, Alexandre Belloni
<alexandre.belloni@...e-electrons.com> wrote:
> +robh
>
> On 14/07/2016 at 22:10:48 +0200, Arnaud Ebalard wrote :
>> Alexandre Belloni <alexandre.belloni@...e-electrons.com> writes:
>>
>> > The ISL12057 has a documentation file, remove it from trivial-devices.txt
>> >
>> > Signed-off-by: Alexandre Belloni <alexandre.belloni@...e-electrons.com>
>> > ---
>> > Documentation/devicetree/bindings/i2c/trivial-devices.txt | 1 -
>> > 1 file changed, 1 deletion(-)
Needs to go to DT list...
>> >
>> > diff --git a/Documentation/devicetree/bindings/i2c/trivial-devices.txt b/Documentation/devicetree/bindings/i2c/trivial-devices.txt
>> > index 539874490492..a397d39ea741 100644
>> > --- a/Documentation/devicetree/bindings/i2c/trivial-devices.txt
>> > +++ b/Documentation/devicetree/bindings/i2c/trivial-devices.txt
>> > @@ -50,7 +50,6 @@ fsl,sgtl5000 SGTL5000: Ultra Low-Power Audio Codec
>> > gmt,g751 G751: Digital Temperature Sensor and Thermal Watchdog with Two-Wire Interface
>> > infineon,slb9635tt Infineon SLB9635 (Soft-) I2C TPM (old protocol, max 100khz)
>> > infineon,slb9645tt Infineon SLB9645 I2C TPM (new protocol, max 400khz)
>> > -isil,isl12057 Intersil ISL12057 I2C RTC Chip
>> > isil,isl29028 Intersil ISL29028 Ambient Light and Proximity Sensor
>> > maxim,ds1050 5 Bit Programmable, Pulse-Width Modulator
>> > maxim,max1237 Low-Power, 4-/12-Channel, 2-Wire Serial, 12-Bit ADCs
>>
>> No strong advice on this but I thought it qualified as a trivial device
>> because it did not *need* anything else except a compatible, an address
>> and possibly an interrupt. The additional boolean property documented in
>> Documentation/devicetree/bindings/rtc/isil,isl12057.txt is optional.
An optional property, then it is not trivial.
>
> Well, my thinking is that trivial devices are in trivial-devices.txt
> because they are not documented anywhere else. This is mostly the case.
Correct.
Rob
Powered by blists - more mailing lists