linux-kernel - Re: [PATCH] ARM: shmobile: don't call platform_can_secondary

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160720231523.GD9599@verge.net.au>
Date:	Thu, 21 Jul 2016 08:15:24 +0900
From:	Simon Horman <horms@...ge.net.au>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:	Arnd Bergmann <arnd@...db.de>, Magnus Damm <magnus.damm@...il.com>,
	Linux-Renesas <linux-renesas-soc@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ARM: shmobile: don't call platform_can_secondary_boot on
 UP

On Thu, Jun 30, 2016 at 03:09:46PM +0200, Geert Uytterhoeven wrote:
> Hi Arnd,
> 
> On Thu, Jun 30, 2016 at 2:25 PM, Arnd Bergmann <arnd@...db.de> wrote:
> > For rcar-gen2, we build the SMP files even for UP configurations,
> > and that just broke:
> >
> > arch/arm/mach-shmobile/built-in.o: In function `shmobile_smp_init_fallback_ops':
> > pm-rcar-gen2.c:(.init.text+0x40c): undefined reference to `platform_can_secondary_boot'
> >
> > This adds an compile-time check before the call to platform_can_secondary_boot,
> > turning the function into an empty stub for UP configurations.
> >
> > Signed-off-by: Arnd Bergmann <arnd@...db.de>
> > Fixes: c21af444eace ("ARM: shmobile: smp: Add function to prioritize DT SMP")
> 
> Crap, I think I took the shortcut of only compile-testing
> arch/arm/mach-shmobile,
> not link-testing the whole kernel, with CONFIG_SMP=n...
> 
> Acked-by: Geert Uytterhoeven <geert+renesas@...der.be>

Sorry for missing this until now.
I have queued it up as a fix for v4.7.