linux-kernel - Re: [PATCH 5/5] mm: consider per-zone inactive ratio to deactivate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160721081611.GG10438@techsingularity.net>
Date:	Thu, 21 Jul 2016 09:16:11 +0100
From:	Mel Gorman <mgorman@...hsingularity.net>
To:	Joonsoo Kim <iamjoonsoo.kim@....com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Johannes Weiner <hannes@...xchg.org>,
	Minchan Kim <minchan@...nel.org>,
	Michal Hocko <mhocko@...e.cz>,
	Vlastimil Babka <vbabka@...e.cz>,
	Linux-MM <linux-mm@...ck.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 5/5] mm: consider per-zone inactive ratio to deactivate

On Thu, Jul 21, 2016 at 04:10:50PM +0900, Joonsoo Kim wrote:
> > @@ -1993,6 +1994,32 @@ static bool inactive_list_is_low(struct lruvec *lruvec, bool file)
> >  	inactive = lruvec_lru_size(lruvec, file * LRU_FILE);
> >  	active = lruvec_lru_size(lruvec, file * LRU_FILE + LRU_ACTIVE);
> >  
> > +	/*
> > +	 * For global reclaim on zone-constrained allocations, it is necessary
> > +	 * to check if rotations are required for lowmem to be reclaimed. This
> > +	 * calculates the inactive/active pages available in eligible zones.
> > +	 */
> > +	if (global_reclaim(sc)) {
> > +		struct pglist_data *pgdat = lruvec_pgdat(lruvec);
> > +		int zid;
> > +
> > +		for (zid = sc->reclaim_idx; zid < MAX_NR_ZONES; zid++) {
> 
> Should be changed to "zid = sc->reclaim_idx + 1"
> 

You're right, well spotted!

-- 
Mel Gorman
SUSE Labs