linux-kernel - Re: [PATCH 3/4] mmu: don't pass *kvm to spte_write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <077ad26d-e12e-f8c6-012b-4a1e50d9888a@redhat.com>
Date:	Thu, 21 Jul 2016 11:15:19 +0200
From:	Paolo Bonzini <pbonzini@...hat.com>
To:	Bandan Das <bsd@...hat.com>, kvm@...r.kernel.org
Cc:	rkrcmar@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/4] mmu: don't pass *kvm to spte_write_protect



On 21/07/2016 00:25, Bandan Das wrote:
> That parameter isn't used in the function,
> it's probably a historical artifact.

Same for spte_clear_dirty and spte_set_dirty, please.

Paolo

> Signed-off-by: Bandan Das <bsd@...hat.com>
> ---
>  arch/x86/kvm/mmu.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c
> index def97b3..aaecd10 100644
> --- a/arch/x86/kvm/mmu.c
> +++ b/arch/x86/kvm/mmu.c
> @@ -1204,7 +1204,7 @@ static void drop_large_spte(struct kvm_vcpu *vcpu, u64 *sptep)
>   *
>   * Return true if tlb need be flushed.
>   */
> -static bool spte_write_protect(struct kvm *kvm, u64 *sptep, bool pt_protect)
> +static bool spte_write_protect(u64 *sptep, bool pt_protect)
>  {
>  	u64 spte = *sptep;
>  
> @@ -1230,7 +1230,7 @@ static bool __rmap_write_protect(struct kvm *kvm,
>  	bool flush = false;
>  
>  	for_each_rmap_spte(rmap_head, &iter, sptep)
> -		flush |= spte_write_protect(kvm, sptep, pt_protect);
> +		flush |= spte_write_protect(sptep, pt_protect);
>  
>  	return flush;
>  }
>