linux-kernel - Re: [PATCH v8 3/3] arm64: dts: rockchip: add usb2-phy support for rk3399

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1ada0c16-9fd8-75b2-6357-1398073ac462@rock-chips.com>
Date:	Thu, 21 Jul 2016 18:17:48 +0800
From:	Frank Wang <frank.wang@...k-chips.com>
To:	Heiko Stübner <heiko@...ech.de>,
	Doug Anderson <dianders@...omium.org>
Cc:	Guenter Roeck <linux@...ck-us.net>,
	Guenter Roeck <groeck@...omium.org>,
	Julius Werner <jwerner@...omium.org>,
	Kishon Vijay Abraham I <kishon@...com>,
	Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"open list:ARM/Rockchip SoC..." <linux-rockchip@...ts.infradead.org>,
	Ziyuan Xu <xzy.xu@...k-chips.com>,
	Kever Yang <kever.yang@...k-chips.com>,
	Tao Huang <huangtao@...k-chips.com>,
	吴良峰 <william.wu@...k-chips.com>,
	daniel.meng@...k-chips.com, frank.wang@...k-chips.com
Subject: Re: [PATCH v8 3/3] arm64: dts: rockchip: add usb2-phy support for
 rk3399

Hi Heiko,

On 2016/7/21 17:26, Heiko Stübner wrote:
> Hi Frank,
>
> Am Donnerstag, 21. Juli 2016, 10:49:53 schrieb Frank Wang:
>>>> @@ -69,6 +69,15 @@
>>>>
>>>>                   regulator-max-microvolt = <3300000>;
>>>>           
>>>>           };
>>>>
>>>> +       vbus_host: vbus-host-regulator {
>>>> +               compatible = "regulator-fixed";
>>>> +               enable-active-high;
>>>> +               gpio = <&gpio4 25 GPIO_ACTIVE_HIGH>;
>>>> +               pinctrl-names = "default";
>>>> +               pinctrl-0 = <&host_vbus_drv>;
>>>> +               regulator-name = "vbus_host";
>>>> +       };
>>>> +
>>> To match my schematics, this would probably be "vcc5v0_host".
>>> Technically there are two regulators but since they are the same
>>> voltage and enabled by the same GPIO it seems like modeling it as one
>>> regulator is fine.
>> Yep, you are right, I will rename it.
>>
>>> If you really wanted to model things you could also include the input
>>> supply (VCC5V0_SYS).  Not sure how much you care to model in EVB.
>> Actually, from
>> "Documentation/devicetree/bindings/regulator/fixed-regulator.txt" show,
>> input supply name is just optional property, and it seems that only do
>> assign "vin" value for input_supply (the second member of struct
>> fixed_voltage_config) if "vin-supply" is specified.
>>
>> So is input supply name  (VCC5V0_SYS) required here? Would you like to
>> give more comments please?
> While vin-supply is optional, I think that is meant for real top-level
> regulators (our vcc_sys or whatever) that really don't have a parent
> regulator.
>
> It is always nicer to model the whole power-tree [in a sane way], as it makes
> following the schematics a lot easier. If you mount a debugfs these days you
> can even get a nice tree graph of the regulator infrastructure ... where the
> parent-relationship is also needed to create something meaningful.
>

Got it, many thanks for your explanation, I will add vin-supply next 
version.


BR.
Frank

> Heiko
>
>
>