linux-kernel - Re: [PATCH 03/18] ARM: mvebu: enable E1000E in mvebu_v7

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160721144647.78fce4a8@free-electrons.com>
Date:	Thu, 21 Jul 2016 14:46:47 +0200
From:	Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>
To:	Russell King - ARM Linux <linux@...linux.org.uk>
Cc:	Grzegorz Jaszczyk <jaz@...ihalf.com>, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	robh+dt@...nel.org, mark.rutland@....com, jason@...edaemon.net,
	andrew@...n.ch, sebastian.hesselbarth@...il.com,
	gregory.clement@...e-electrons.com, mw@...ihalf.com,
	alior@...vell.com
Subject: Re: [PATCH 03/18] ARM: mvebu: enable E1000E in mvebu_v7_defconfig

Hello,

On Thu, 21 Jul 2016 13:44:09 +0100, Russell King - ARM Linux wrote:
> On Thu, Jul 21, 2016 at 02:43:59PM +0200, Grzegorz Jaszczyk wrote:
> > Signed-off-by: Grzegorz Jaszczyk <jaz@...ihalf.com>  
> 
> Why?  It's not like this is an on-soc device, but most likely a PCIe card.
> Should we build-in all PCIe drivers?

I agree.

> I think it makes more sense to have this as a module rather than built-in.

I would prefer to not have it all in the defconfig. I'd hate to have
a defconfig that builds tons of random modules "just because".

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com