linux-kernel - Re: [PATCH resend] intel_rapl: downgrade message if no RAPL domains found in a VM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1617795.yheICcaOFs@vostro.rjw.lan>
Date:	Thu, 21 Jul 2016 15:19:28 +0200
From:	"Rafael J. Wysocki" <rjw@...ysocki.net>
To:	Paolo Bonzini <pbonzini@...hat.com>
Cc:	linux-kernel@...r.kernel.org, Thomas Renninger <trenn@...e.de>,
	Peter Zijlstra <peterz@...radead.org>,
	linux-pm@...r.kernel.org,
	Jacob Pan <jacob.jun.pan@...ux.intel.com>,
	Andy Lutomirski <luto@...capital.net>
Subject: Re: [PATCH resend] intel_rapl: downgrade message if no RAPL domains found in a VM

On Tuesday, July 19, 2016 01:49:57 PM Paolo Bonzini wrote:
> People complain about the driver saying there's no valid RAPL domains
> in a VM, and doing so at KERN_ERR severity.  Downgrade this to KERN_INFO
> if running on a hypervisor, since it is basically stating the obvious.
> 
> Suggested-by: Peter Zijlstra <peterz@...radead.org>
> Cc: Jacob Pan <jacob.jun.pan@...ux.intel.com>
> Cc: Andy Lutomirski <luto@...capital.net>
> Signed-off-by: Paolo Bonzini <pbonzini@...hat.com>
> ---
> 	First sent out about a year ago. :)
> 
>  drivers/powercap/intel_rapl.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/powercap/intel_rapl.c b/drivers/powercap/intel_rapl.c
> index b2766b867b0e..0a0b09910116 100644
> --- a/drivers/powercap/intel_rapl.c
> +++ b/drivers/powercap/intel_rapl.c
> @@ -1392,7 +1392,9 @@ static int rapl_detect_domains(struct rapl_package *rp, int cpu)
>  	}
>  	rp->nr_domains = bitmap_weight(&rp->domain_map,	RAPL_DOMAIN_MAX);
>  	if (!rp->nr_domains) {
> -		pr_err("no valid rapl domains found in package %d\n", rp->id);
> +		printk("%sNo valid RAPL domains found in package %d\n",
> +		       boot_cpu_has(X86_FEATURE_HYPERVISOR) ? KERN_INFO : KERN_ERR,
> +		       rp->id);

But we print that message with pr_debug() now (as in linux-next).

Do you still want to do anything about that?

>  		ret = -ENODEV;
>  		goto done;
>  	}
> 

Thanks,
Rafael