linux-kernel - Re: staging: ks7010: Delete unnecessary uses of the variable "retval"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160721163545.GA1616@katana>
Date:	Thu, 21 Jul 2016 18:35:46 +0200
From:	Wolfram Sang <wsa@...-dreams.de>
To:	Julia Lawall <julia.lawall@...6.fr>
Cc:	SF Markus Elfring <elfring@...rs.sourceforge.net>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	devel@...verdev.osuosl.org, LKML <linux-kernel@...r.kernel.org>,
	kernel-janitors@...r.kernel.org
Subject: Re: staging: ks7010: Delete unnecessary uses of the variable "retval"


> > * Do you really want to assign every return value from a function call
> >   to an extra variable before it is used again?
> 
> If it's a choice between 1) function call on many lines, 2) function call
> over 80 characters, and 3) extra variable, I definitely prefer the extra
> variable.

+1


Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)