linux-kernel - Re: [PATCH 13/13] rapidio/switches: add driver for IDT gen3 switches

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160721120158.7aeb709ee13469295a250deb@linux-foundation.org>
Date:	Thu, 21 Jul 2016 12:01:58 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	"Bounine, Alexandre" <Alexandre.Bounine@....com>
Cc:	Matt Porter <mporter@...nel.crashing.org>,
	Andre van Herk <andre.van.herk@...drive-technologies.com>,
	"Wood, Barry" <Barry.Wood@....com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 13/13] rapidio/switches: add driver for IDT gen3
 switches

On Thu, 21 Jul 2016 18:48:17 +0000 "Bounine, Alexandre" <Alexandre.Bounine@....com> wrote:

> > > +		udelay(10);
> > > +		rio_write_config_32(rdev, RIO_PLM_SPx_IMP_SPEC_CTL(pnum),
> > rval);
> > > +		mdelay(500);
> > 
> > Yikes, that's a very long busywait.  A half-second machine freeze on
> > uniprocessor (if such exists ;)).  We can't use msleep()?
> > 
> 
> My bad ;) No problem with msleep() at all. We just need to give enough time
> for Rapidio link to get back (spec defines 500mS).
> Do you want a patch on patch? 

Patch on patch is good.  But something tested, please ;)