linux-kernel - [PATCH] crypto: x86/glue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1469139180-26863-1-git-send-email-mcgrof@kernel.org>
Date:	Thu, 21 Jul 2016 15:13:00 -0700
From:	"Luis R. Rodriguez" <mcgrof@...nel.org>
To:	herbert@...dor.apana.org.au, davem@...emloft.net,
	paul.gortmaker@...driver.com
Cc:	lkp@...org, linux-crypto@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	"Luis R. Rodriguez" <mcgrof@...nel.org>
Subject: [PATCH] crypto: x86/glue_helper make bool

Paul's changes to remove MODULE_LICENSE() out of the x86 glue_helper
causes a kernel with CONFIG_CRYPTO_GLUE_HELPER_X86=m to taint since
it now detects the license is missing if you try to build the driver
as a module, log below.

Fix this by removing the module option for it via Kconfig as it
cannot be a module.

glue_helper: module license 'unspecified' taints kernel.
glue_helper: module license 'unspecified' taints kernel.
Disabling lock debugging due to kernel taint
glue_helper: Unknown symbol blkcipher_walk_done (err 0)
glue_helper: Unknown symbol blkcipher_walk_virt (err 0)
glue_helper: Unknown symbol kernel_fpu_end (err 0)
glue_helper: Unknown symbol kernel_fpu_begin (err 0)
glue_helper: Unknown symbol blkcipher_walk_virt_block (err 0)
glue_helper: Unknown symbol blkcipher_walk_done (err 0)
glue_helper: Unknown symbol blkcipher_walk_virt (err 0)
glue_helper: Unknown symbol kernel_fpu_end (err 0)
glue_helper: Unknown symbol kernel_fpu_begin (err 0)
glue_helper: Unknown symbol blkcipher_walk_virt_block (err 0)
glue_helper: Unknown symbol blkcipher_walk_done (err 0)
glue_helper: Unknown symbol blkcipher_walk_virt (err 0)
glue_helper: Unknown symbol kernel_fpu_end (err 0)
glue_helper: Unknown symbol kernel_fpu_begin (err 0)
glue_helper: Unknown symbol blkcipher_walk_virt_block (err 0)
glue_helper: Unknown symbol blkcipher_walk_done (err 0)
glue_helper: Unknown symbol blkcipher_walk_virt (err 0)
glue_helper: Unknown symbol kernel_fpu_end (err 0)
glue_helper: Unknown symbol kernel_fpu_begin (err 0)
glue_helper: Unknown symbol blkcipher_walk_virt_block (err 0)

Signed-off-by: Luis R. Rodriguez <mcgrof@...nel.org>
---
 crypto/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/crypto/Kconfig b/crypto/Kconfig
index a9377bef25e3..ed6abf4bbf3b 100644
--- a/crypto/Kconfig
+++ b/crypto/Kconfig
@@ -237,7 +237,7 @@ config CRYPTO_ABLK_HELPER
 	select CRYPTO_CRYPTD

 config CRYPTO_GLUE_HELPER_X86
-	tristate
+	bool
 	depends on X86
 	select CRYPTO_ALGAPI

-- 
2.8.4