linux-kernel - Re: [PATCH] crypto: x86/glue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160721230607.GA5537@wotan.suse.de>
Date:	Fri, 22 Jul 2016 01:06:07 +0200
From:	"Luis R. Rodriguez" <mcgrof@...nel.org>
To:	Paul Gortmaker <paul.gortmaker@...driver.com>
Cc:	"Luis R. Rodriguez" <mcgrof@...nel.org>,
	herbert@...dor.apana.org.au, davem@...emloft.net, lkp@...org,
	linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] crypto: x86/glue_helper make bool

On Thu, Jul 21, 2016 at 07:01:11PM -0400, Paul Gortmaker wrote:
> [[PATCH] crypto: x86/glue_helper make bool] On 21/07/2016 (Thu 15:13) Luis R. Rodriguez wrote:
> 
> > Paul's changes to remove MODULE_LICENSE() out of the x86 glue_helper
> > causes a kernel with CONFIG_CRYPTO_GLUE_HELPER_X86=m to taint since
> > it now detects the license is missing if you try to build the driver
> > as a module, log below.
> 
> Reported and fixed two days ago ; the fix went out in yesterday's
> linux-next via the tip tree.
> 
> https://lkml.kernel.org/r/20160719144243.GK21225@windriver.com
> 
> I fixed it by restoring the license, since making it bool might break
> existing use cases,

How so?

  Luis