linux-kernel - Re: [PATCH v6 1/2] [media] atmel-isc: add the Image Sensor Controller code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ebd3617c-ad3c-d0e0-e024-b72924b5f864@xs4all.nl>
Date:	Fri, 22 Jul 2016 09:21:07 +0200
From:	Hans Verkuil <hverkuil@...all.nl>
To:	"Wu, Songjun" <Songjun.Wu@...rochip.com>, nicolas.ferre@...el.com,
	robh@...nel.org
Cc:	laurent.pinchart@...asonboard.com,
	linux-arm-kernel@...ts.infradead.org, linux-media@...r.kernel.org,
	Arnd Bergmann <arnd@...db.de>,
	Niklas SÃ¶derlund 
	<niklas.soderlund+renesas@...natech.se>,
	Benoit Parrot <bparrot@...com>, linux-kernel@...r.kernel.org,
	Andrew-CT Chen <andrew-ct.chen@...iatek.com>,
	Sudip Mukherjee <sudipm.mukherjee@...il.com>,
	Kamil Debski <kamil@...as.org>,
	Tiffany Lin <tiffany.lin@...iatek.com>,
	Peter Griffin <peter.griffin@...aro.org>,
	Geert Uytterhoeven <geert@...ux-m68k.org>,
	Mikhail Ulyanov <mikhail.ulyanov@...entembedded.com>,
	Richard Röjfors <richard@...finpack.se>,
	Hans Verkuil <hans.verkuil@...co.com>,
	Laurent Pinchart <laurent.pinchart+renesas@...asonboard.com>,
	Simon Horman <horms+renesas@...ge.net.au>
Subject: Re: [PATCH v6 1/2] [media] atmel-isc: add the Image Sensor Controller
 code



On 07/22/2016 07:18 AM, Wu, Songjun wrote:

<snip>

>>> +/*
>>> + * index(0~11):  raw formats.
>>> + * index(12~12): the formats which can be converted from raw format by ISC.
>>> + * index():      the formats which can only be provided by subdev.
>>> + */
>>> +static struct isc_format isc_formats[] = {
>>
>> static const
>>
> Some members in structure isc_format need be modified, so it can not be 
> const.

OK. Please add a comment about that.

Regards,

	Hans