linux-kernel - Re: [PATCH 2/2] ARM: DRA7: select PCI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 22 Jul 2016 13:56:47 +0530
From:	Kishon Vijay Abraham I <kishon@...com>
To:	Tony Lindgren <tony@...mide.com>, Arnd Bergmann <arnd@...db.de>
CC:	<bcousson@...libre.com>, <robh+dt@...nel.org>,
	<mark.rutland@....com>, <linux@...linux.org.uk>,
	<linux-omap@...r.kernel.org>, <devicetree@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>,
	<linux-kernel@...r.kernel.org>, <linux-pci@...r.kernel.org>,
	<nsekhar@...com>
Subject: Re: [PATCH 2/2] ARM: DRA7: select PCI_DOMAINS config

Hi,

On Friday 22 July 2016 12:46 PM, Tony Lindgren wrote:
> * Arnd Bergmann <arnd@...db.de> [160721 05:08]:
>> On Thursday, July 21, 2016 5:27:56 PM CEST Kishon Vijay Abraham I wrote:
>>> diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig
>>> index 1a648e9..8e6e2c0 100644
>>> --- a/arch/arm/mach-omap2/Kconfig
>>> +++ b/arch/arm/mach-omap2/Kconfig
>>> @@ -86,6 +86,7 @@ config SOC_DRA7XX
>>>         select OMAP_INTERCONNECT_BARRIER
>>>         select PM_OPP if PM
>>>         select ZONE_DMA if ARM_LPAE
>>> +       select PCI_DOMAINS if PCI
>>>  
>>>  config ARCH_OMAP2PLUS
>>>         bool
>>>
>>
>> Should we just set this unconditionally for ARCH_MULTIPLATFORM maybe?
> 
> Makes sense to me if many SoCs need this.

since it doesn't harm even if a platform has a single PCIe port, it should be
okay to set PCI_DOMAINS. I'll resend the following as a separate patch if it's
okay.

diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 90542db..0cccb50 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -338,6 +338,7 @@ config ARCH_MULTIPLATFORM
        select MULTI_IRQ_HANDLER
        select SPARSE_IRQ
        select USE_OF
+       select PCI_DOMAINS if PCI

 config ARM_SINGLE_ARMV7M
        bool "ARMv7-M based platforms (Cortex-M0/M3/M4)"

Thanks
Kishon