linux-kernel - Re: Aw: BUG: Wrong dma queue handling in ixp4 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m3lh0urnc4.fsf@t19.piap.pl>
Date:	Fri, 22 Jul 2016 12:14:51 +0200
From:	khalasa@...p.pl (Krzysztof Hałasa)
To:	"Lino Sanfilippo" <LinoSanfilippo@....de>
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: Aw: BUG: Wrong dma queue handling in ixp4 driver

Hi Lino,

"Lino Sanfilippo" <LinoSanfilippo@....de> writes:

>> maybe I miss something, but the ixp4 ethernet driver seems to handle dma pools 
>> in a wrong way: In init_queues() it creates a dma pool for descriptors and then
>>  only allocates a single descriptor from this pool. The author seems to assume the whole
>> table has been allocated already, since after that the complete pool size is zeroed:
>> 
>
> Sorry, I indeed missed something. The allocation is correct. A pool is not required, though,
> since only one chunk is allocated.

Not really: there is one pool for all ports, but each port uses
a separate desc_tab (allocated from that pool).
-- 
Krzysztof Halasa

Industrial Research Institute for Automation and Measurements PIAP
Al. Jerozolimskie 202, 02-486 Warsaw, Poland