linux-kernel - Re: [PATCH] vfs:Fix memory leak on error path in get_empty

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHkRjk5zZAXcZJMFbfX2Winx8+1Ddk3YmFPbb7ruAZ1LGv1ARg@mail.gmail.com>
Date:	Fri, 22 Jul 2016 11:47:35 +0100
From:	Catalin Marinas <catalin.marinas@....com>
To:	Nicholas Krause <xerofoify@...il.com>
Cc:	Al Viro <viro@...iv.linux.org.uk>, linux-fsdevel@...r.kernel.org,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] vfs:Fix memory leak on error path in get_empty_file

I can't find the original post (probably it only went to the
linux-fsdevel list), so replying to Nicholas here:

> On Thu, Jul 21, 2016 at 10:53:37PM -0400, Nicholas Krause wrote:
>> This fixes a memory leak on the error path if the call to
>> security_file_alloc fails to run successfully as detected
>> in this trace by kmemleak:
>> [  321.783718] ath9k 0000:03:00.0 eth0: renamed from wlan0
>> [  330.960024] atl1c 0000:02:00.0 eth1: renamed from eth126
>> [  391.831384] WARNING: kmemcheck: Caught 64-bit read from uninitialized memory (ffff8800a8ad8a00)

Can you please understand that kmemleak != kmemcheck, even though the
names are similar? It would save both your and other developers' time.
See the corresponding Kconfig help text:

KMEMCHECK: "kmemcheck: trap use of uninitialized memory"
DEBUG_KMEMLEAK: "Kernel memory leak detector"

-- 
Catalin