[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20160722105648.GD17584@leverpostej>
Date: Fri, 22 Jul 2016 11:56:49 +0100
From: Mark Rutland <mark.rutland@....com>
To: Tan Xiaojun <tanxiaojun@...wei.com>
Cc: robh+dt@...nel.org, pawel.moll@....com,
ijc+devicetree@...lion.org.uk, galak@...eaurora.org,
xuwei5@...ilicon.com, devicetree@...r.kernel.org,
khilman@...aro.org, k.kozlowski@...sung.com, amitdanielk@...il.com,
heiko@...ech.de, wxt@...k-chips.com, alex.aring@...il.com,
qiang.zhao@...escale.com, treding@...dia.com,
rmk+kernel@....linux.org.uk, gregory.clement@...e-electrons.com,
f.fainelli@...il.com, geert+renesas@...der.be,
linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [RFC PATCH v1 0/2] Add Hisilicon Djtag driver
Hi,
I understand that some SoC/socket level PMU is accessed via these
registers. It doesn't make sense to review either in isolation. Please
put together a unified series, with both the djtag accessors and the
PMU code.
On it's own, it's *very* difficult to understand how this fits into the
SoC, and how it is to be used.
Thanks,
Mark.
On Fri, Jul 22, 2016 at 04:48:50PM +0800, Tan Xiaojun wrote:
>
> Tan Xiaojun (2):
> Documentation: arm64: Add Hisilicon HiP05/06/07 Sysctrl and Djtag dts
> bindings
> drivers: soc: Add support for Hisilicon Djtag driver
>
> .../bindings/arm/hisilicon/hisilicon.txt | 98 +++++
> drivers/soc/Kconfig | 1 +
> drivers/soc/Makefile | 1 +
> drivers/soc/hisilicon/Kconfig | 12 +
> drivers/soc/hisilicon/Makefile | 1 +
> drivers/soc/hisilicon/djtag.c | 373 ++++++++++++++++++++
> include/linux/soc/hisilicon/djtag.h | 18 +
> 7 files changed, 504 insertions(+)
> create mode 100644 drivers/soc/hisilicon/Kconfig
> create mode 100644 drivers/soc/hisilicon/Makefile
> create mode 100644 drivers/soc/hisilicon/djtag.c
> create mode 100644 include/linux/soc/hisilicon/djtag.h
>
> --
> 1.7.9.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
Powered by blists - more mailing lists