lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 22 Jul 2016 14:06:20 +0200 From: Michal Marek <mmarek@...e.com> To: Dave Young <dyoung@...hat.com>, "Tautschnig, Michael" <tautschn@...zon.co.uk> Cc: "linux-kbuild@...r.kernel.org" <linux-kbuild@...r.kernel.org>, "kexec@...ts.infradead.org" <kexec@...ts.infradead.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Vivek Goyal <vgoyal@...hat.com> Subject: Re: [PATCH] scripts: Fix size mismatch of kexec_purgatory_size On 2016-07-06 10:45, Dave Young wrote: > On 07/04/16 at 01:55pm, Tautschnig, Michael wrote: >> bin2c is used to create a valid C file out of a binary file where two >> symbols will be globally defined: <name> and <name>_size. <name> is >> passed as the first parameter of the host binary. >> >> Building using goto-cc reported that the purgatory binary code (the only >> current user of this utility) declares kexec_purgatory_size as 'size_t' >> where bin2c generate <name>_size to be 'int' so in a 64-bit host where >> sizeof(size_t) > sizeof(int) this type mismatch will always yield the >> wrong value for big-endian architectures while for little-endian it will >> be wrong if the object laid in memory directly after >> kexec_purgatory_size contains non-zero value at the time of reading. >> >> This commit changes <name>_size to be size_t instead. >> >> Note: >> >> Another way to fix the problem is to change the type of >> kexec_purgatory_size to be 'int' as there's this check in code: >> (kexec_purgatory_size <= 0) >> >> Signed-off-by: Michael Tautschnig <tautschn@...zon.com> >> Cc: Michal Marek <mmarek@...e.com> >> Cc: Vivek Goyal <vgoyal@...hat.com> [...] > Acked-by: Dave Young <dyoung@...hat.com> Applied to kbuild.git#kbuild. Michal
Powered by blists - more mailing lists