linux-kernel - Re: [PATCH] reset: return -ENOTSUPP if CONFIG_RESET

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1469191192.27223.17.camel@pengutronix.de>
Date:	Fri, 22 Jul 2016 14:39:52 +0200
From:	Philipp Zabel <p.zabel@...gutronix.de>
To:	Masahiro Yamada <yamada.masahiro@...ionext.com>
Cc:	linux-kernel@...r.kernel.org, Hans de Goede <hdegoede@...hat.com>,
	Lee Jones <lee.jones@...aro.org>
Subject: Re: [PATCH] reset: return -ENOTSUPP if CONFIG_RESET_CONTROLLER is
 undefined

Hi Masahiro,

Am Donnerstag, den 21.07.2016, 14:06 +0900 schrieb Masahiro Yamada:
> This has been inconsistent; some returns -EINVAL, some -ENOTSUPP.
> Make it consistent in this header, in favor of -ENOTSUPP.
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>
> ---
> 
>  include/linux/reset.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/linux/reset.h b/include/linux/reset.h
> index 5894f0f..c875b4b 100644
> --- a/include/linux/reset.h
> +++ b/include/linux/reset.h
> @@ -71,14 +71,14 @@ static inline struct reset_control *__of_reset_control_get(
>  					struct device_node *node,
>  					const char *id, int index, int shared)
>  {
> -	return ERR_PTR(-EINVAL);
> +	return ERR_PTR(-ENOTSUPP);
>  }
>  
>  static inline struct reset_control *__devm_reset_control_get(
>  					struct device *dev,
>  					const char *id, int index, int shared)
>  {
> -	return ERR_PTR(-EINVAL);
> +	return ERR_PTR(-ENOTSUPP);
>  }
>  
>  #endif /* CONFIG_RESET_CONTROLLER */

Thanks, this has already been changed in commit 168d7c4e8bb2 ("reset:
Return -ENOTSUPP when not configured").

regards
Philipp